Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase Liblouis version number to 3.28.0 version #101

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

hammera
Copy link
Contributor

@hammera hammera commented Dec 4, 2023

Hi Boys,

As it is usual after new Liblouis stable release publication, I updated into Liblouisutdml source tree the proper files to synchronise the version number the new version (now with increasing Liblouis version number from 3.27.0 to 3.28.0 version number).
If this is possible, please approve and merget this little changes the master branch.
Affected files:

  • Dockerfile.win32,
  • Dockerfile.win64,
  • .github/workflows/main.yml,
  • .github/workflows/sanitizer.yml.
    If future the community would like publicating a new Liblouisutdml release (after 2024. march or 2024. june for example), better to syncing the Liblouis version number the actual stable release.
    Note: anybody not known an automatic possibility, similar with dependabot handles the required dependency versions in Liblouis to always inclease Liblouis version number when releasing a new Liblouis stable version (for example in 2024. march, 2024. june, 2024. september and 2024. december)? :-):-)
    Roughly, an automatic Github operation file would be good, which always increases the version number of Liblouis in the four source files to the version number of the current Liblouis stable release the day after the publication of the current Liblouis release, and then automatically submits a pull request as, e.g. at Liblouis, dependabot does this when different component version numbers change (golang version number, scorecard version number change, etc.). :-):-)

If the last part related my english is not full good, sorry, hopefully you understanding what can I would like suggesting.

Attila

Signed-off-by: Attila Hammer <hammera@pickup.hu>
@hammera
Copy link
Contributor Author

hammera commented Dec 4, 2023

This is interesting.
When my local system I ran make check command, from 386 total tests is 210 tests passed if I exported with LOUIS_TABLEPATH environment value with /usr/src/liblouis/tables.
The online check results I see 5 failed test the test-suite.log file.
My local test-suite.log part result is following (I not installed yet entire Liblouis 3.28.0 release my distribution, because tomorrow I need doing a fresh package):

================================================
   liblouisutdml 2.12.0: tests/test-suite.log
================================================

# TOTAL: 386
# PASS:  210
# SKIP:  0
# XFAIL: 176
# FAIL:  0
# XPASS: 0
# ERROR: 0

If I creating tomorrow the fresh package, will be looking what tests are failing.

Attila

@hammera
Copy link
Contributor Author

hammera commented Dec 5, 2023

Ok, I see now what tests failing In real environment with uses Liblouis 3.28.0 (not only tables, but changed libs with affects perhaps the precedence order).
After upgraded my machine the Liblouis packages the fresh 3.28.0 version, following tests are real failing if I running my local system the make check command the tests directory in Liblouisutdml source tree:

  • test_mathml_woluwe/test_080.test,
  • test_mathml_woluwe/test_106.test,
  • test_mathml_woluwe/test_107.test,
  • test_mathml_woluwe/test_113.test,
  • test_mathml_woluwe/test_114.test.

@bertfrees, you knowing best the voluve MATH Braille (this tests I think uses ../../lbu_files/wiskunde.sem, nl-unicode.dis,../../lbu_files/wiskunde.ctb,braille-patterns.cti in literaryTexttable, nl-unicode.dis,../../lbu_files/wiskunde.ctb,braille-patterns.cti the mathtextTable preference, nl-unicode.dis,../../lbu_files/wiskunde.ctb,braille-patterns.cti the mathexprTable preference, and en-us-brf.dis,braille-patterns.cti,../../lbu_files/wiskunde_edit.ctb tables the editTable preference in tests/math_voluve/liblouisutdml.ini file.

Since the order of precedence was changed right before the release of Liblouis version 3.28.0, maybe for the base operator code (or something similar, I can't think of the correct Liblouis call request that implemented this change), what is the correct expected for these failed tests .txt value?
Could you check the error list of the failed tests, and maybe if the values of the tests are really wrong according to the new Liblouis version, could you fix them in the corresponding files before we switch the version number? I hope it is not necessary to make corrections in one of the sub-tables of Liblouis in connection with these tests, I will attach the error list. :-(:-(
If so, the only thing I can do at the moment is to temporarily put these tests in xfail state (if this is a feasible way) until the errors in the tests are corrected in the affected subtable of Liblouis.
I really hope that either one of the wiskunde.ctb or wiskunde_edit.ctb tables or the expected.txt files are faulty, and not some of the sub-tables of the new Liblouis version produce malfunctions only in these tests.
Final I founded the pull request with change the rule precedence order, but I am not sure this change produces the failing test results this five math voluve tests:
Liblouis pull request #1481

Attila

@hammera
Copy link
Contributor Author

hammera commented Dec 5, 2023

failed_tests.txt
I attaching the error list how looks the error list with five failing math volume tests.
If not have better way, we need put xfail state this five tests until not fixing the issue this tests in Liblouisutdml proper table, expected.txt files or Liblouis proper affected subtable files.

Thanks the investigation and error list examination,

Attila

Following tests produce failures with Liblouis 3.28.0 and Liblouis latest master
branch version:
* test_mathml_woluwe/test_080.test,
* test_mathml_woluwe/test_106.test,
* test_mathml_woluwe/test_107.test,
* test_mathml_woluwe/test_113.test,
* test_mathml_woluwe/test_114.test

Signed-off-by: Attila Hammer <hammera@pickup.hu>
@hammera
Copy link
Contributor Author

hammera commented Dec 8, 2023

Nice, all checks are passed now.
Following tests I marked xfail into the tests/Makefile.am until lbu_files directory the wiskunde.ctb tables are not actualized the Liblouis 3.28.0 version:

  • test_mathml_woluwe/test_080.test,
  • test_mathml_woluwe/test_106.test,
  • test_mathml_woluwe/test_107.test,
  • test_mathml_woluwe/test_113.test,
  • test_mathml_woluwe/test_114.test

If acceptable my change, please approve these changes.

Thanks the cooperation,

Attila

@egli egli merged commit 681149e into liblouis:master Jan 17, 2024
5 checks passed
@egli egli added this to the 2.13 milestone Feb 2, 2024
@egli egli added the needs news label Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants